Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): bump libs and driver to 0.18.0-rc1. #3320

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 11, 2024

What type of PR is this?

/kind release

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 11, 2024

/milestone 0.39.0

@poiana poiana requested review from incertum and Kaizhe September 11, 2024 09:53
@poiana poiana added this to the 0.39.0 milestone Sep 11, 2024
@poiana poiana added the size/XS label Sep 11, 2024
LucaGuerra
LucaGuerra previously approved these changes Sep 11, 2024
Andreagit97
Andreagit97 previously approved these changes Sep 11, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 11, 2024

CI Build / check-engine-checksum (pull_request) Failing after 8s

Uh need to bump engine version and checksum!
Will do it in a moment!

EDIT: because of falcosecurity/libs#1936

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP dismissed stale reviews from Andreagit97 and LucaGuerra via 885cffc September 11, 2024 10:06
@poiana poiana added size/S and removed size/XS labels Sep 11, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d14825f into master Sep 11, 2024
35 checks passed
@poiana poiana deleted the update/libs_0.18.0-rc1 branch September 11, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants