-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(systemd): add falco.service alias to all systemd units #3332
update(systemd): add falco.service alias to all systemd units #3332
Conversation
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
Welcome @ekoops! It looks like this is your first PR to falcosecurity/falco 🎉 |
Very nice fix, thank you! /milestone 0.39.0 |
As you can see,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 0105b25c4b0349fe68769a9a7ee9bcb182877f80
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, ekoops, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR allows to refer to the engine
systemd
services with a consistent unique aliasfalco.service
. In addition, the aliassystemd
system helps to prevent from running more than one Falco instance withsystemd
at the time, since it is not possible to enable twosystemd
service, with the same alias, at the same time.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: