feat(falco/app): move actions not using config before load_config
#3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
ekoops
force-pushed
the
ekoops/anticipate-app-actions
branch
from
b4b7924 to
e6985ca
Compare
|
/unhold |
poiana
added
release-note-none
and removed
do-not-merge/hold
do-not-merge/release-note-label-needed
labels
sgaist
previously approved these changes
Feb 5, 2025
|
LGTM label has been added. Git tree hash: 360ef8fd74500a4b97fa131526c9c6aa5dabcf08
|
Move actions not requiring config to be loaded before `load_config` action. This avoid resource waste. Notably, `print_help` is promoted as first execution action. Moreover, set actions lists to constant expressions. Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
ekoops
force-pushed
the
ekoops/anticipate-app-actions
branch
from
e6985ca to
c5db6c5
Compare
|
LGTM label has been added. Git tree hash: 55366616085074c68715e2fc1341ed34d41b6ee0
|
|
/milestone 0.41.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR moves, before the
load_configaction, all actions not requiring the config to be loaded. This avoid resources waste. Notably, it promotesprint_helpas first executed action. Moreover, it sets actions lists to constant expressions.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: