Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule update (mkdirat + clear log activities placeholder) #667

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Jun 12, 2019

  1. Extend macro mkdir with syscall mkdirat (Alerts for mkdir should include mkdirat #337)
  2. add placeholder for whitelist in rule Clear Log Activities (Provide macro to whitelist "Clear Log Activities" Rule #632)

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flaky-test

If contributing rules or changes to rules, please make sure to uncomment the appropriate kind

/kind rule/update

/kind rule/create

Any specific area of the project related to this PR?

/area engine
/area rules
/area deployment
/area integrations
/area examples

What this PR does / why we need it:
Address #337 and #632

Which issue(s) this PR fixes:

Fixes #
#337
#632

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. Extend macro mkdir with syscall mkdirat (#337)
2. add placeholder for whitelist in rule Clear Log Activities (#632)

@leodido
Copy link
Member

leodido commented Jun 13, 2019

Thanks @Kaizhe! Could you sign your commits only please?

@poiana
Copy link
Contributor

poiana commented Jun 13, 2019

LGTM label has been added.

Git tree hash: b4b4719bee3194c8290144927734b93454f581d8

@leodido leodido changed the title rule update rule update (mkdirat + clear log activities placeholder) Jun 13, 2019
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🙌🙌🙌

@poiana poiana removed the lgtm label Jun 13, 2019
1. Extend macro mkdir with syscall mkdirat (#337)
2. add placeholder for whitelist in rule Clear Log Activities (#632)

Signed-off-by: kaizhe <derek0405@gmail.com>

add docker.io/ to the trusted images list

Signed-off-by: kaizhe <derek0405@gmail.com>

rule update: add container.id and image in the rule output except those rules with "not container" in condition

Signed-off-by: kaizhe <derek0405@gmail.com>

Remove empty line

Signed-off-by: Kaizhe Huang<derek0405@gmail.com>
@mstemm
Copy link
Contributor

mstemm commented Jun 13, 2019

\lgtm

@poiana poiana added the lgtm label Jun 13, 2019
@poiana
Copy link
Contributor

poiana commented Jun 13, 2019

LGTM label has been added.

Git tree hash: 26dcf0752b7623df7f70cdd731c7b1ccd5bb45c1

@poiana
Copy link
Contributor

poiana commented Jun 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cfaa52f into dev Jun 13, 2019
@poiana poiana deleted the rule-updates-2019-06.v1 branch June 13, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants