-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s deployment yaml files for audit purpose only #729
Conversation
/assign @mstemm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this PR, really appreciated! 🤗
A few initial observations.
Currently we have integrations/k8s-using-daemonset
directory.
The integrations
directory probably needs a re-organization.
Just to be in pair with the current structure can we put this integration under integrations/k8s-using-deployment
?
Furthermore atm I think that falco-k8s-audit.yaml
config file is not something that have to be in the root of the source.
2e5b224
to
6a9c8ce
Compare
I've made corresponding changes per your suggestions. Maybe syscall_event_drops section should be removed and syslog_output could be set to false? |
@mfdii PTAL |
/hold blocked by #730 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think that this can now be accomplished since #730 had been done (but not released yet). |
@fntlnz I've modified my PR to add the new --disable-source flag and removed some extra config and rule files. Would you help to review this ? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Just a couple of nits then we are good to go!
ok @benjaminhuo we are just waiting for you to accept the renaming changes then we can merge this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pick the suggestions or give us access to our fork?
In that way we could edit this PR and merge it! :)
Signed-off-by: Benjamin <benjamin@yunify.com>
I've merged your suggestions and force pushed the new changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
LGTM label has been added. Git tree hash: 6ab2904d1126e329e76904da8d5d9f49a57821ff
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Signed-off-by: Benjamin benjamin@yunify.com
What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area integrations
What this PR does / why we need it:
DaemonSet is more than enough for just monitoring k8s audit event, a deployment should be enough.
Which issue(s) this PR fixes:
Fixes #725
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes