-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore sensitive mounts from ecs-agent #881
Ignore sensitive mounts from ecs-agent #881
Conversation
Welcome @fcoelho! It looks like this is your first PR to falcosecurity/falco 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (it works as intended!) but can be probably engineered better (not creating a macro but using the macro already in place for such goal).
LGTM label has been added. Git tree hash: 131dbeedc25777b322fff4856e6a6cb7b913205b
|
Hi @fcoelho - good catch, thanks for finding it! I tested this on ECS and can totally reproduce. However can you please use the |
Without this, as ecs-agent starts we get a bunch of errors that look like this (reformatted for readability): Notice Container with sensitive mount started ( user=root command=init -- /agent ecs-agent (id=19d4e98bb0dc) image=amazon/amazon-ecs-agent:latest mounts=/proc:/host/proc:ro:false:rprivate,$lotsofthings ) ecs-agent needs those to work properly, so this can cause lots of false positives when starting a new instance. Signed-off-by: Felipe Bessa Coelho <fcoelho.9@gmail.com>
@fntlnz Just pushed that change instead, tested locally and seems to do the job too |
/lgtm |
LGTM label has been added. Git tree hash: 6794aa1789e08b29ef62dc4103ba5128cafece35
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Kaizhe, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind rule-update
/area rules
What this PR does / why we need it:
Without this, as ecs-agent starts we get a bunch of errors that look
like this (reformatted for readability):
ecs-agent needs those to work properly, so this can cause lots of false
positives when starting a new instance.
Special notes for your reviewer:
This can be reproduced on ami
ami-0da6ab8acebc7f9db
in regionsa-east-1
or any Amazon Linux 2 ECS-optimized ami (name pattern likeamzn2-ami-ecs-hvm-*-x86_64-ebs
)Installed falco using the following commands:
Does this PR introduce a user-facing change?: