Use falcoctl 0.0.3 w/ unique names #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the changes in falcosecurity/falcoctl#25 that make sure rules, macros, lists, and rule names all have a unique prefix. In this case the prefix is based on the psp name, so make sure the psp name actually reflects what it does--there were a few cut-and-paste carryovers. This test assumes that falcoctl will be tagged/released as 0.0.3--the tests won't pass until the falcoctl PR is merged and there's a release. Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
mstemm
force-pushed
the
use-falcoctl-0_0_3
branch
from
0b885d6 to
182e284
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: d7757cfecacb606ab0a423dd9f09480b5c69194f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the changes in falcosecurity/falcoctl#25
that make sure rules, macros, lists, and rule names all have a unique
prefix. In this case the prefix is based on the psp name, so make sure
the psp name actually reflects what it does--there were a few
cut-and-paste carryovers.
This test assumes that falcoctl will be tagged/released as 0.0.3--the
tests won't pass until the falcoctl PR is merged and there's a release.
Signed-off-by: Mark Stemm mark.stemm@gmail.com
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: