Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules update: add more sensitive host path to sensitive_host_mount macro #929

Merged
merged 5 commits into from
Dec 3, 2019

Conversation

Kaizhe
Copy link
Contributor

@Kaizhe Kaizhe commented Nov 19, 2019

Signed-off-by: kaizhe derek0405@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
Add more sensitive host paths to sensitive_mount macro

Which issue(s) this PR fixes:
N/A

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

rules(macro sensitive_vol_mount): add more sensitive host paths
rules(macro sensitive_mount): add more sensitive paths

mstemm
mstemm previously approved these changes Nov 19, 2019
@poiana
Copy link
Contributor

poiana commented Nov 19, 2019

LGTM label has been added.

Git tree hash: f7fe7455a307c773ad6a59b8b7adc898d0f791fb

fntlnz
fntlnz previously approved these changes Nov 19, 2019
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM but errors in the CI needs a bit of investigation 👀

Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
Signed-off-by: kaizhe <derek0405@gmail.com>
@Kaizhe Kaizhe dismissed stale reviews from fntlnz and mstemm via cb9f03c December 2, 2019 19:14
@Kaizhe Kaizhe force-pushed the rule-updates-2019-11.v2 branch from 5f9b386 to cb9f03c Compare December 2, 2019 19:14
@Kaizhe Kaizhe requested review from fntlnz, mstemm and leodido and removed request for leodido December 2, 2019 21:02
@leodido leodido self-requested a review December 3, 2019 19:36
@poiana
Copy link
Contributor

poiana commented Dec 3, 2019

LGTM label has been added.

Git tree hash: fbf6cda54ec0fc7c7d8f0e3adb63984bad12efa4

@poiana
Copy link
Contributor

poiana commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Dec 3, 2019
@leodido leodido merged commit 722ab4f into dev Dec 3, 2019
@poiana poiana deleted the rule-updates-2019-11.v2 branch December 3, 2019 19:37
@leodido
Copy link
Member

leodido commented Dec 4, 2019

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants