Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code changes to support ppc64le platform #932

Closed
wants to merge 1 commit into from
Closed

Code changes to support ppc64le platform #932

wants to merge 1 commit into from

Conversation

sunil1783
Copy link

@sunil1783 sunil1783 commented Nov 21, 2019 •
edited by leodido
Loading

Signed-off-by: Sunil1783 sunil.botre@ibm.com

What type of PR is this?
kind/feature

Any specific area of the project related to this PR?
area/build

What this PR does / why we need it:
These code changes will support falco on Ubuntu 18.04 ppc64le platform.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
These code changes will support falco code on Ubuntu 18.04 ppc64le platform.
Enabled the -DBUILD_BPF=True while compiling the code using CMAKE to provide eBPF support.

cmake -DBUILD_BPF=True -DCMAKE_VERBOSE_MAKEFILE=On
-DCPACK_SOURCE_RPM=ON -DUSE_BUNDLED_DEPS=ON ..

Does this PR introduce a user-facing change?

new: support for ppc64le platform

@poiana
Copy link
Contributor

poiana commented Nov 21, 2019

Welcome @sunil1783! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana requested review from fntlnz and mstemm November 21, 2019 12:46
@poiana poiana added the size/M label Nov 21, 2019
@fntlnz
Copy link
Contributor

fntlnz commented Nov 25, 2019

Hi @sunil1783 - I'd like falco to support the ppc64le platform. However the way you are doing it here completely drops support for x86. We can discuss on a way to design this so that both are kept and many more can come.

@leodido leodido self-requested a review November 25, 2019 23:26
leodido
leodido reviewed Nov 25, 2019
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this! :)

This needs some work still imho.

In the meantime could you please use the complete PR template (release notes missing) ?

leodido
leodido reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this SGTM.

A question, maybe I missed something, but why do we need to change the base image of falco-tester docker image to have this to work?

If the problem is the avocado versions can't we just specify them in the falco-tester we already have?

docker/tester/root/usr/bin/entrypoint Outdated Show resolved Hide resolved
@sunil1783 sunil1783 mentioned this pull request Dec 18, 2019
Closed
@poiana poiana added size/S and removed size/M labels Dec 18, 2019
@poiana
Copy link
Contributor

poiana commented Dec 23, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kris-nova
You can assign the PR to them by writing /assign @kris-nova in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added size/M and removed size/S labels Dec 23, 2019
@sunil1783
Copy link
Author

Created issue for test case failures on ppc64le.
Currently all the falco test cases are passed, except test case which required falcosecurity/falco:test docker image.
#982.

Need help/suggetions to port the Dockefiles for ppc64le platform which downloads Intel specific gcc6&5 dependent pre-built packages.

@sunil1783 sunil1783 mentioned this pull request Jan 21, 2020
Closed
@leogr leogr added this to the 0.24.0 milestone May 18, 2020
@fntlnz
Copy link
Contributor

fntlnz commented Jun 26, 2020

Let's keep this open since it has good points for the tests too - we need to decide the direction with #1225

@leodido
Copy link
Member

leodido commented Jul 15, 2020

/milestone 0.25.0

@poiana poiana modified the milestones: 0.24.0, 0.25.0 Jul 15, 2020
@leogr leogr modified the milestones: 0.25.0, 0.26.0 Aug 25, 2020
@krisnova krisnova modified the milestones: 0.26.0, 0.27.0 Sep 24, 2020
@poiana
Copy link
Contributor

poiana commented Nov 25, 2020

@sunil1783: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fntlnz fntlnz modified the milestones: 0.27.0, 0.28.0 Jan 15, 2021
@leodido
Copy link
Member

leodido commented Apr 9, 2021

/milestone 0.28.1

@poiana poiana modified the milestones: 0.28.0, 0.28.1 Apr 9, 2021
@leogr leogr modified the milestones: 0.28.1, 0.29.0 Apr 26, 2021
@leogr leogr modified the milestones: 0.29.0, 0.30.0 Jun 17, 2021
@poiana
Copy link
Contributor

poiana commented Sep 15, 2021

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr leogr modified the milestones: 0.30.0, 0.31.0 Sep 28, 2021
@poiana
Copy link
Contributor

poiana commented Oct 28, 2021

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Nov 28, 2021

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana
Copy link
Contributor

poiana commented Nov 28, 2021

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodido leodido leodido left review comments

@fntlnz fntlnz Awaiting requested review from fntlnz

@mstemm mstemm Awaiting requested review from mstemm

Assignees
No one assigned
Labels
dco-signoff: yes lifecycle/rotten needs-rebase release-note size/L
Projects
None yet
Milestone
0.31.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sunil1783 @poiana @fntlnz @leodido @leogr @krisnova