update: cleanup the gRPC dependency and use the url from the main project #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject Signed-off-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
|
LGTM label has been added. Git tree hash: d8f28ed6bcc65e8a9ae85e83419c08a689dc299a
|
|
/milestone 0.19.0 |
Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
leodido
approved these changes
Nov 27, 2019
|
LGTM label has been added. Git tree hash: 29e623fa0144ee34335e6b138096438335d4149a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lorenzo Fontana lo@linux.com
What type of PR is this?
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
I noticed that Falco wasn't compiling on some machines because gRPC was not being handled righty by CMake so I'm sending this with the needed changes.
Also I did some cleanup and changed the download url to be the one of the main project, checksums are matching.
This is also preparation work for #921 since we will need to update gRPC and this was needed to be prepared for that.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: