Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falcoctl install probe #21

Merged
merged 6 commits into from
Oct 11, 2019
Merged

falcoctl install probe #21

merged 6 commits into from
Oct 11, 2019

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Oct 11, 2019

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area library

/area cli

What this PR does / why we need it:

This PR ports the httploader tool from this PR on Falco falcosecurity/falco#776 to the falcoctl under the form of falcoctl install probe. This tool will figure out how to download the pre-built Falco probe for this kernel (the kernel module) and load it.

Which issue(s) this PR fixes:

Fixes #20

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cli: new command falcoctl install probe

fntlnz and others added 5 commits October 11, 2019 13:03
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Michael Ducy <michael@ducy.org>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Michael Ducy <michael@ducy.org>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Michael Ducy <michael@ducy.org>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Michael Ducy <michael@ducy.org>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Co-Authored-By: Michael Ducy <michael@ducy.org>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
Issif
Issif previously approved these changes Oct 11, 2019
@poiana poiana added the lgtm label Oct 11, 2019
@poiana
Copy link
Contributor

poiana commented Oct 11, 2019

LGTM label has been added.

Git tree hash: 2b0504e6ac9b102b985468680f7b593287ac3d6b

@Issif Issif removed their assignment Oct 11, 2019
Copy link

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@poiana poiana added the lgtm label Oct 11, 2019
@poiana
Copy link
Contributor

poiana commented Oct 11, 2019

LGTM label has been added.

Git tree hash: aa56f0c79ba65cfef2f40983d5a556b881e596d0

@poiana
Copy link
Contributor

poiana commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, markyjackson-taulia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [leodido,markyjackson-taulia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fntlnz fntlnz changed the title wip: falcoctl install probe falcoctl install probe Oct 11, 2019
@poiana poiana merged commit 2be3df9 into master Oct 11, 2019
@poiana poiana deleted the feat/probe-installer branch October 11, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the build slim images tool here
5 participants