fix(version): correctly set falcoctl version at build time #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each time a falcoctl artifact (binary/OCI image) is created we make sure that the falcoctl binary has the version fields set. Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: e10a4df87813d81d8bb4d69c2f1d979786811d66
|
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aldo Lacuku aldo@lacuku.eu
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
What this PR does / why we need it:
Falcoctl version is set at build time. This PR adjusts the CI to always set the correct version when publishing a
falcoctlartifact being it a binary or an OCI image.Which issue(s) this PR fixes:
#236
Fixes #
Special notes for your reviewer: