Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: introduce allowedTypes #251

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Feb 3, 2023

Signed-off-by: Lorenzo Susini susinilorenzo1@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:
Falcoctl is able to download any kind of artifacts, including shared libraries that could be potentially used by Falco and loaded. For security reasons, we want to let users be able to decide which kind of artifacts falcoctl is allowed to pull by means of a whitelist. If the list is empty everything is allowed for ease of use.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana requested review from alacuku and maxgio92 February 3, 2023 17:56
@poiana poiana added the size/L label Feb 3, 2023
@loresuso loresuso force-pushed the new/introduce-permitted-types branch 3 times, most recently from 9dd6b8d to a507d93 Compare February 4, 2023 11:00
…pe of artifacts

It does so by retrieving the manifest and checking the mediaType from layer[0]
(the one and only for our artifacts)

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@loresuso loresuso force-pushed the new/introduce-permitted-types branch from a507d93 to 3dfeed8 Compare February 4, 2023 11:22
@loresuso loresuso changed the title wip: new: introduce allowedTypes new: introduce allowedTypes Feb 4, 2023
…ollow

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@loresuso loresuso force-pushed the new/introduce-permitted-types branch 2 times, most recently from 668d9a2 to 3fbb30e Compare February 6, 2023 11:59
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@loresuso loresuso force-pushed the new/introduce-permitted-types branch from 3fbb30e to 3cf1f49 Compare February 6, 2023 13:42
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana
Copy link
Contributor

poiana commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Feb 6, 2023
@poiana
Copy link
Contributor

poiana commented Feb 6, 2023

LGTM label has been added.

Git tree hash: cfef034a22ce905b7db06462f408ce3f95af2989

@poiana poiana added the approved label Feb 6, 2023
@poiana poiana merged commit bc12026 into falcosecurity:main Feb 6, 2023
@leogr leogr added this to the v0.4.0 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants