Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add backend 'https' to default index #520

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: Add backend 'https' to default index #520

merged 1 commit into from
Apr 17, 2024

Conversation

qjoly
Copy link
Contributor

@qjoly qjoly commented Apr 17, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area cli

What this PR does / why we need it:

This PR will fix the issue #519 by adding the missing 'backend' field when generating the default configuration

old :

indexes:
    - name: falcosecurity
      url: https://falcosecurity.github.io/falcoctl/index.yaml

new:

indexes:
    - name: falcosecurity
      url: https://falcosecurity.github.io/falcoctl/index.yaml
      backend: "https"

Which issue(s) this PR fixes:

Fixes #519

huge thanks to the contributors to the Falco project and its ecosystem.

@poiana
Copy link
Contributor

poiana commented Apr 17, 2024

Welcome @qjoly! It looks like this is your first PR to falcosecurity/falcoctl 🎉

Signed-off-by: QJoly <quentinj@une-pause-cafe.fr>
@FedeDP
Copy link
Contributor

FedeDP commented Apr 17, 2024

Hi! Thanks for this fix, it makes sense!
/milestone v0.8.0

@poiana poiana added this to the v0.8.0 milestone Apr 17, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 17, 2024

LGTM label has been added.

Git tree hash: 08af20e515d1ee9999751b12c76597d691e9cb7c

@poiana
Copy link
Contributor

poiana commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, QJoly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Apr 17, 2024

Mmmh tide is dead i think. I will try to close and reopen this one.
/close

@poiana poiana closed this Apr 17, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Apr 17, 2024

/reopen

@poiana
Copy link
Contributor

poiana commented Apr 17, 2024

@FedeDP: Closed this PR.

In response to this:

Mmmh tide is dead i think. I will try to close and reopen this one.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana reopened this Apr 17, 2024
@poiana
Copy link
Contributor

poiana commented Apr 17, 2024

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit e5bc056 into falcosecurity:main Apr 17, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "backend" field on default index
3 participants