-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add backend 'https' to default index #520
Conversation
Welcome @qjoly! It looks like this is your first PR to falcosecurity/falcoctl 🎉 |
Signed-off-by: QJoly <quentinj@une-pause-cafe.fr>
Hi! Thanks for this fix, it makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 08af20e515d1ee9999751b12c76597d691e9cb7c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, QJoly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Mmmh tide is dead i think. I will try to close and reopen this one. |
/reopen |
@FedeDP: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@FedeDP: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
This PR will fix the issue #519 by adding the missing 'backend' field when generating the default configuration
old :
new:
Which issue(s) this PR fixes:
Fixes #519
huge thanks to the contributors to the Falco project and its ecosystem.