Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg/oci): fix Tags pagination support. #671

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Nov 20, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area library

What this PR does / why we need it:

When tags are paginated, we need to continuously append to our resulting slice instead of overwriting it.
Example output before:

./falcoctl artifact info cloudtrail-rules --config=config.yaml 
REF                                             	TAGS
ghcr.io/falcosecurity/plugins/ruleset/cloudtrail	

Example output after:

./falcoctl artifact info cloudtrail-rules --config=config.yaml 
REF                                             	TAGS
ghcr.io/falcosecurity/plugins/ruleset/cloudtrail	latest, 0, 0.7, 0.7.0, 0.7.1, 0.7.2, 0.7.3, 0.8, 0.8.0, 0.9, 0.9.0, 0.9.1, 0.10, 0.10.0, 0.11, 0.11.0, main, 0.12, 0.12.0, 0.12.1, 0.12.2, 0.12.3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is also affecting whole Falco CI: https://github.com/falcosecurity/falco/actions/runs/11932413814?pr=3407

/cc @alacuku

I propose to put this one in a patch release for falcoctl and package it with Falco 0.39.2.
cc @leogr

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@alacuku
Copy link
Member

alacuku commented Nov 20, 2024

Nice catch!

Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants