added fission output type #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
|
Welcome @gauravgahlot! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
Issif
requested changes
Jul 17, 2021
outputs/client.go
Outdated
| @@ -209,6 +209,8 @@ func (c *Client) Post(payload interface{}) error { | |||
| } else if c.OutputType == Openfaas { | |||
| log.Printf("[INFO] : %v - Function Response : %v\n", Openfaas, | |||
| string(body)) | |||
| } else if c.OutputType == Fission { | |||
| log.Printf("[INFO] : %v - Function Response : %v\n", Openfaas, string(body)) | |||
There was a problem hiding this comment.
Suggested change
| log.Printf("[INFO] : %v - Function Response : %v\n", Openfaas, string(body)) | |
| log.Printf("[INFO] : %v - Function Response : %v\n", Fission, string(body)) |
|
Really nice first PR 👍 |
Issif
requested changes
Jul 17, 2021
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
gauravgahlot
force-pushed
the
output-type-fission
branch
from
d9af1fc to
61b0431
Compare
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
Signed-off-by: Gaurav Gahlot <gauravgahlot0107@gmail.com>
|
/assign |
|
LGTM label has been added. Git tree hash: f398130bcec757f8bd5f226c9a0cf7f26d5d5643
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravgahlot, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaurav Gahlot gauravgahlot0107@gmail.com
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR adds Fission as an output module. So, we can start sending events to the Fission functions.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Work in progress.