feat(prometheus-hostname): adding hostname from playload as label of prom events metric #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
reviewed
Mar 20, 2023
Lowaiz
force-pushed
the
feat/prometheus-event-hostname
branch
from
5dcfaed
to
87d642f
Compare
…el of prom metric Signed-off-by: Lyonel Martinez <lyonel.martinez@numberly.com>
Lowaiz
force-pushed
the
feat/prometheus-event-hostname
branch
from
87d642f
to
4d81d73
Compare
Issif
approved these changes
Mar 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, Lowaiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: e090b3ef29cc7aa459610089f71843aaa6f47a3d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
The Sidekick doesn't give the hostname to the prom metrics leading to monitoring a simple global count of event when used outside of Kubernetes nodes.
Which issue(s) this PR fixes:
None