Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Grafana OnCall output #470

Merged
merged 1 commit into from
May 9, 2023
Merged

add Grafana OnCall output #470

merged 1 commit into from
May 9, 2023

Conversation

Issif
Copy link
Member

@Issif Issif commented May 4, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

Add Grafana OnCall output

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Thomas Labarussias <issif_github@gadz.org>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cool

@poiana
Copy link

poiana commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented May 4, 2023

LGTM label has been added.

Git tree hash: 08fd4ea0a57a1eafc842b47c6cbb319e6bc8c614

@Issif
Copy link
Member Author

Issif commented May 4, 2023

@cpanato let's keep this PR in WIP for now, I'm facing an issue I don't understand https://community.grafana.com/t/wrong-title-for-incidents-in-oncall/86998

@cpanato
Copy link
Member

cpanato commented May 4, 2023

/hold

@Issif Issif changed the title WIP: add Grafana OnCall output add Grafana OnCall output May 9, 2023
@Issif
Copy link
Member Author

Issif commented May 9, 2023

/unhold

@poiana poiana merged commit 05d5bae into master May 9, 2023
@poiana poiana deleted the grafana-oncall branch May 9, 2023 20:21
@Issif Issif added this to the 2.28.0 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants