Add attributes to GCP PubSub messages #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
|
Welcome @annadorottya! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
annadorottya
force-pushed
the
gcp-pubsub-attributes
branch
from
b9a3fd1
to
7f9d918
Compare
Signed-off-by: Anna Simon <asimon@mercari.com>
annadorottya
force-pushed
the
gcp-pubsub-attributes
branch
from
7f9d918
to
78de8d3
Compare
Issif
approved these changes
Jun 9, 2023
|
LGTM label has been added. Git tree hash: 340652977800d281e89acb140f2737392adcce2a
|
|
Thank you @Issif , do I need to do anything else to get it merged? |
Issif
approved these changes
Jun 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annadorottya, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area config
/area outputs
What this PR does / why we need it: Adds list of key-value pairs in the config below the
pubsuboption, which will be added to all the output messages as attributes.Which issue(s) this PR fixes: #504
Fixes #
Special notes for your reviewer: