Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S3 output compatible with non-AWS S3 API-compliant endpoints #791

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

gysel
Copy link
Contributor

@gysel gysel commented Feb 20, 2024

Changes:

  • add AWS.S3.Endpoint configuration option
  • make canned ACL configurable
  • add MinIO to docker-compose.yaml for local testing

/kind feature
/area outputs

I tested this change against IBM Cloud COS and a local MinIO instance.

Example config.yaml for the local MinIO:

aws:
  region: minio
  checkidentity: false
  accesskeyid: xxx
  secretaccesskey: xxx
  s3:
    bucket: falco-test
    endpoint: http://minio.localhost:9000
    objectcannedacl: ""

- add AWS.S3.Endpoint configuration option
- make canned ACL configurable
- add minio to docker-compose.yaml for local testing

Signed-off-by: Michael Gysel <michael.gysel@unblu.com>
@poiana
Copy link

poiana commented Feb 20, 2024

Welcome @gysel! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana requested review from cpanato and Issif February 20, 2024 14:56
@poiana poiana added the size/M label Feb 20, 2024
@Issif Issif added this to the 2.29.0 milestone Feb 20, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! thanks!

@poiana
Copy link

poiana commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gysel, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Feb 20, 2024

LGTM label has been added.

Git tree hash: 792a5d3a8fca7ca6218f16b8da7333a81a4bad83

@poiana poiana merged commit 709419b into falcosecurity:master Feb 20, 2024
5 checks passed
@gysel gysel deleted the s3-endpoint branch February 20, 2024 18:47
@gysel
Copy link
Contributor Author

gysel commented Feb 20, 2024

Thanks for the quick review & merge! Looking forward to the next release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants