Add GCP PubSub output feature #97
Conversation
|
Welcome @IanRobertson-wpe! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
Awesome. Thanks @IanRobertson-wpe. Can you sign-off your commits please, our CI will refuse to merge without. For my part I'll review and comment your changes. |
|
I think you should rebase on upstream and fix conflicts too, please. |
|
After your rebase, could you integrate falcosidekick/outputs/slack.go Line 136 in d35ff2b |
IanRobertson-wpe
force-pushed
the
master
branch
from
40b9be7
to
5fee49e
Compare
IanRobertson-wpe
force-pushed
the
master
branch
from
5fee49e
to
557d4d1
Compare
IanRobertson-wpe
force-pushed
the
master
branch
from
8586dd5
to
955bf64
Compare
Signed-off-by: Issif <issif_github@gadz.org> Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
The deployment instructions for falcosidekick seem to be outdated. Signed-off-by: Pierre-Yves Aillet <pyaillet@gmail.com> Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Co-authored-by: Thomas Labarussias <issif+github@gadz.org> Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Co-authored-by: Thomas Labarussias <issif+github@gadz.org> Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Co-authored-by: Thomas Labarussias <issif+github@gadz.org> Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
Signed-off-by: Ian Robertson <ian.robertson@wpengine.com>
IanRobertson-wpe
force-pushed
the
master
branch
from
955bf64
to
5636b19
Compare
|
LGTM label has been added. Git tree hash: 0d75a6ec169994a16c51121d3e5224845a222234
|
|
/lgtm 👍 @IanRobertson-wpe thanks a lot, I will release 2.17.0 asap for sure |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This adds a PubSub output for users of Google Cloud Platform.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This has been tested in a GKE environment on 8 varying clusters with 50+ nodes. 100% 'ok' observed through /debug/vars endpoint with over 90k alerts generated.