Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(kernel_crawler): rename distro keys to match os-release names. #188

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Oct 23, 2023

This is what we expect in driverkit, dbg-go and test-infra.

This is a BREAKING CHANGE

/cc @maxgio92 @EXONER4TED
/hold for discussion.

See previous #185

@EXONER4TED
Copy link
Contributor

I'm all for this, been wondering why they weren't synced up haha. I am not in office today though - I have a sick kiddo I'm taking care of 🙁

I'll approve this tomorrow when I get in so that I can make the necessary changes downstream to handle it.

Thanks!

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 23, 2023

I have a sick kiddo I'm taking care of 🙁

Welcome to new school's year i guess? 🤣

I'll approve this tomorrow when I get in so that I can make the necessary changes downstream to handle it.

Great!

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 23, 2023

Also @EXONER4TED please note that, as stated here: falcosecurity/test-infra#1118 (comment) i force pushed main branch of kernel-crawler removing any fat json from the history (since at the start of the repo life, kernels lists were pushed to the main branch, not the kernels one).
This was made to reduce repo size and hopefully fix falcosecurity/test-infra#1118 issue.
I think we must cleanup something else too, ie: there are still unreferenced blobs objects in the repo.

This is what we expect in driverkit, dbg-go and test-infra.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the new/rename_keys_to_osrelease branch from b609c13 to b13529a Compare October 24, 2023 07:56
@maxgio92
Copy link
Member

/lgtm

@maxgio92
Copy link
Member

/cc @EXONER4TED

@maxgio92 maxgio92 assigned EXONER4TED and unassigned maxgio92 Oct 24, 2023
It is needed to refresh kernels lists allowing `dbg-go` CI to pass with the new
distro keys.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@@ -2,6 +2,7 @@
name: Update Kernels

on:
workflow_dispatch:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to trigger a refresh of kernels lists, allowing falcosecurity/dbg-go#36 CI to be green.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, we can leave it there, it makes no harm after all.

Copy link
Contributor

@EXONER4TED EXONER4TED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back in office today - approving

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 24, 2023

/unhold

@poiana poiana merged commit ea70cb9 into main Oct 24, 2023
3 checks passed
@poiana poiana deleted the new/rename_keys_to_osrelease branch October 24, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants