-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(kernel_crawler): rename distro keys to match os-release names. #188
Conversation
I'm all for this, been wondering why they weren't synced up haha. I am not in office today though - I have a sick kiddo I'm taking care of 🙁 I'll approve this tomorrow when I get in so that I can make the necessary changes downstream to handle it. Thanks! |
Welcome to new school's year i guess? 🤣
Great! |
Also @EXONER4TED please note that, as stated here: falcosecurity/test-infra#1118 (comment) i force pushed main branch of kernel-crawler removing any fat json from the history (since at the start of the repo life, kernels lists were pushed to the main branch, not the |
This is what we expect in driverkit, dbg-go and test-infra. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
b609c13
to
b13529a
Compare
/lgtm |
/cc @EXONER4TED |
It is needed to refresh kernels lists allowing `dbg-go` CI to pass with the new distro keys. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@@ -2,6 +2,7 @@ | |||
name: Update Kernels | |||
|
|||
on: | |||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to trigger a refresh of kernels lists, allowing falcosecurity/dbg-go#36 CI to be green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, we can leave it there, it makes no harm after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back in office today - approving
/unhold |
This is what we expect in driverkit, dbg-go and test-infra.
This is a BREAKING CHANGE
/cc @maxgio92 @EXONER4TED
/hold for discussion.
See previous #185