Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

refactor: group presubmit tests together #88

Conversation

francesco-racciatti
Copy link
Contributor

What this PR does / why we need it:

This PR groups presubmit tests together to reduce confusion in workflow.

Moreover, this PR bumps:

  • golang to 1.20 version
  • GH actions versions

francesco-racciatti and others added 4 commits November 23, 2023 15:50
Signed-off-by: francesco-racciatti <francesco.racciatti@sysdig.com>
Signed-off-by: francesco-racciatti <francesco.racciatti@sysdig.com>
Signed-off-by: francesco-racciatti <francesco.racciatti@sysdig.com>
@poiana
Copy link

poiana commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: francesco-racciatti
Once this PR has been reviewed and has the lgtm label, please assign gnosek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested a review from gnosek November 23, 2023 21:03
@poiana
Copy link

poiana commented Nov 23, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@poiana
Copy link

poiana commented Nov 23, 2023

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented Nov 23, 2023

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the falcosecurity org. You can then trigger verification by writing /verify-owners in a comment.

  • francesco-racciatti
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • pgcrooks-sysdig
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@pgcrooks-sysdig pgcrooks-sysdig deleted the refactor-presubmit-tests branch November 24, 2023 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants