Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): fixed 6.4 kernel build #1110

Merged
merged 1 commit into from
May 29, 2023

Conversation

hhoffstaette
Copy link
Contributor

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?
/area driver-kmod

Does this PR require a change in the driver versions?
/version driver-API-version-patch

What this PR does / why we need it:
A kernel API change in 6.4 requires a build fix

Which issue(s) this PR fixes:
Fixes #1109

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Holger Hoffstätte <holger@applied-asynchrony.com>
@hhoffstaette
Copy link
Contributor Author

Adding an #ifdef at the call site seemed easiest - if there is a better way please let me know. It's backwards-compatible and should not pose any problems.

@FedeDP
Copy link
Contributor

FedeDP commented May 19, 2023

Faster than Linus himself 😆

/milestone next-driver

@poiana poiana added this to the next-driver milestone May 19, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 19, 2023

LGTM label has been added.

Git tree hash: 6701f00a820d5134f2cb9416ae16bf9876b92558

@Andreagit97
Copy link
Member

/hold

@FedeDP
Copy link
Contributor

FedeDP commented May 29, 2023

/milestone 5.0.1+driver

@poiana poiana modified the milestones: next-driver, 5.0.1+driver May 29, 2023
@FedeDP
Copy link
Contributor

FedeDP commented May 29, 2023

/unhold

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit b017900 into falcosecurity:master May 29, 2023
@poiana
Copy link
Contributor

poiana commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, hhoffstaette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hhoffstaette hhoffstaette deleted the fix-build-on-6.4 branch May 29, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scap-driver: fails to compile with kernel 6.4
4 participants