Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: support build for wasm #1156

Merged
merged 12 commits into from
Aug 3, 2023
Merged

Conversation

Rohith-Raju
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

/area CI

/area tests

Does this PR require a change in the driver versions?

What this PR does / why we need it:

This PR adds support to WASM target. This is a preliminary work for Google Summer of Code
falcosecurity/evolution#262

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: support build for wasm

@github-actions
Copy link

github-actions bot commented Jun 20, 2023

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@Rohith-Raju Rohith-Raju changed the title WIP: Support build for wasm using emscripten WIP: update: support build for wasm Jun 20, 2023
@poiana poiana added size/XL and removed size/XXL labels Jun 20, 2023
@jasondellaluce jasondellaluce force-pushed the emcc_build branch 4 times, most recently from 3254f87 to a003251 Compare June 20, 2023 14:24
@jasondellaluce jasondellaluce changed the title WIP: update: support build for wasm update: support build for wasm Jun 20, 2023
@jasondellaluce
Copy link
Contributor

/milestone 0.12.0

@poiana poiana added this to the 0.12.0 milestone Jun 20, 2023
@jasondellaluce
Copy link
Contributor

This is ready for review! Me and @Rohith-Raju worked on this for the GSoC project. This is preliminary work for having a working Falco build for WASM.

cc @falcosecurity/libs-maintainers

@jasondellaluce
Copy link
Contributor

Shoutout to @Rohith-Raju for the great work here! 🥳

@FedeDP
Copy link
Contributor

FedeDP commented Jun 20, 2023

Incredible job @Rohith-Raju and Jason! Thank you very much!
/milestone 0.12.0

userspace/libscap/scap.c Outdated Show resolved Hide resolved
cmake/modules/libsinsp.cmake Outdated Show resolved Hide resolved
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Left a couple of comments, but PR LGTM!

Rohith-Raju and others added 12 commits August 3, 2023 09:36
Signed-off-by: Rohith Raju <rohithraju488@gmail.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Rohith Raju <rohithraju488@gmail.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Rohith Raju <rohithraju488@gmail.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Rohith Raju <rohithraju488@gmail.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Rohith Raju <rohithraju488@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: rohith-raju <rohithraju488@gmail.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Rohith Raju <rohithraju488@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Rohith Raju <rohithraju488@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Rohith Raju <rohithraju488@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce
Copy link
Contributor

The Driver SCHEMA_VERSION checks failure is a false positive here.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 3, 2023

LGTM label has been added.

Git tree hash: f2e6284609b6fcbae2d25ab24e1a207ca2b93826

@poiana poiana added the approved label Aug 3, 2023
@Andreagit97
Copy link
Member

/approve

@poiana
Copy link
Contributor

poiana commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, Rohith-Raju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants