cleanup: re-audit some critical code paths to avoid nullptr dereference #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Andreagit97
force-pushed
the
fix_some_nullptr_issues
branch
from
a845804
to
811dc5f
Compare
|
LGTM label has been added. Git tree hash: 507aa532a02f1b1d1a607a2b6f24340c13d2c43a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-modern-bpf
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR is a follow-up of #1236. While in the previous PR we really faced a bug, here we are just preventing some possible future issues. We never faced a null pointer dereference in these cases but never say never... unfortunately it has a cost in terms of perf, directly referencing memory is surely more efficient than using bpf_probe_read helpers but we need to find a good trade-off between stability and efficiency so probably here is better to be a little bit more conservative
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: