update(cmake): propagate position-independent code option to dependencies #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cies Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
poiana
added
kind/cleanup
dco-signoff: yes
kind/feature
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
|
LGTM label has been added. Git tree hash: 73d30b78773ae63bd219d45a7220c00d5b4984cc
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Our CMake files support an
ENABLE_PICflag that enforces code to compiled as position-independent. That is triggered in the scope of building the libs as shared objects. However, it's generally not possible to build position-independent executables from static builds of the libs due to the fact that the PIC option is not propagated to any of dependencies when building them bundled.This PR simply makes sure the option is propagated consistently across the bundled libs dependencies.
Which issue(s) this PR fixes:
Special notes for your reviewer:
/milestone 0.18.0
Does this PR introduce a user-facing change?: