Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libsinsp): use size_type in basename transformer #1945

Merged

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

As per title

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(libsinsp): use size_type in basename transformer, fix build on Windows

Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana
Copy link
Contributor

poiana commented Jul 4, 2024

LGTM label has been added.

Git tree hash: 7b883a61ade0c41aa643fefc684f628dc72bab8b

@FedeDP
Copy link
Contributor

FedeDP commented Jul 4, 2024

/milestone 0.19.0

@poiana
Copy link
Contributor

poiana commented Jul 4, 2024

@FedeDP: The provided milestone is not valid for this repository. Milestones in this repository: [0.18.0, TBD, next-driver]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 0.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Jul 4, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Jul 4, 2024
@poiana poiana merged commit 3eae0fa into falcosecurity:master Jul 4, 2024
42 of 43 checks passed
@LucaGuerra LucaGuerra deleted the fix/ssize_t-compilation-failed branch July 4, 2024 08:18
Copy link

github-actions bot commented Jul 4, 2024

Perf diff from master - unit tests

     9.54%     -2.55%  [.] sinsp::next
     9.85%     +1.88%  [.] sinsp_parser::reset
     5.88%     -1.42%  [.] sinsp_evt::get_type
     6.41%     -1.38%  [.] sinsp_thread_manager::find_thread
     3.74%     +0.83%  [.] sinsp_parser::process_event
     0.65%     +0.81%  [.] 0x00000000000e7540
     2.44%     +0.80%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     0.94%     +0.49%  [.] sinsp::fetch_next_event
     4.75%     +0.49%  [.] next
     0.10%     +0.49%  [.] sinsp_evt::is_filtered_out

Perf diff from master - scap file

     8.39%     +5.25%  [.] sinsp_filter_check::extract_nocache
     7.72%     -2.08%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     3.92%     +2.06%  [.] libsinsp::runc::match_one_container_id
     3.91%     +1.85%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<sinsp_container_info const> >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::shared_ptr<sinsp_container_info const> > >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     3.99%     +1.84%  [.] sinsp_filter_check_thread::extract_single
     4.00%     +1.73%  [.] sinsp_evt_formatter::tostring_withformat
    17.14%     +0.73%  [.] sinsp_filter_check::tostring
     7.13%     +0.72%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
    11.96%     -0.36%  [.] sinsp_filter_check::rawval_to_string
     4.15%     -0.23%  [.] sinsp_filter_check::apply_transformers

Heap diff from master - unit tests

total runtime: -0.09s.
calls to allocation functions: -670 (7528/s)
temporary memory allocations: -185 (2078/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.00s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: -9 (-4500/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants