-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(userspace/libsinsp): only link libanl if present. #2036
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Putting this in milestone 0.19. |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2036 +/- ##
=======================================
Coverage 74.31% 74.31%
=======================================
Files 253 253
Lines 30966 30966
Branches 5403 5393 -10
=======================================
Hits 23011 23011
+ Misses 7942 7927 -15
- Partials 13 28 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 0.18.0 |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
libanl is only available for glibc; only link it when it is present in the system.
Also, this is another step forward to support building libs with
zig
compiler.Which issue(s) this PR fixes:
Fixes #1948
Special notes for your reviewer:
Does this PR introduce a user-facing change?: