Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): don't run drivers CI job that use secrets on forks. #2041

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 2, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

They would always fail.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

poiana commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Sep 2, 2024

Perf diff from master - unit tests

     9.63%     +1.73%  [.] sinsp_parser::reset
     6.24%     -1.56%  [.] sinsp_evt::get_type
     6.69%     +0.98%  [.] sinsp::next
     3.52%     -0.90%  [.] sinsp_thread_manager::find_thread
     3.16%     +0.89%  [.] sinsp_thread_manager::get_thread_ref
     2.20%     -0.76%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     5.76%     -0.70%  [.] next
     4.76%     -0.69%  [.] sinsp_parser::process_event
     1.28%     +0.61%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.16%     -0.52%  [.] scap_next

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0376         +0.0376           145           151           145           151
BM_sinsp_split_median                                          +0.0376         +0.0376           145           151           145           151
BM_sinsp_split_stddev                                          -0.3092         -0.3098             1             1             1             1
BM_sinsp_split_cv                                              -0.3343         -0.3349             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1151         +0.1151            42            47            42            47
BM_sinsp_concatenate_paths_relative_path_median                +0.1150         +0.1151            42            47            42            47
BM_sinsp_concatenate_paths_relative_path_stddev                -0.3653         -0.3648             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.4308         -0.4304             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0165         -0.0164            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0166         -0.0166            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.0485         -0.0505             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.0326         -0.0346             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1160         +0.1161            43            48            43            48
BM_sinsp_concatenate_paths_absolute_path_median                +0.1108         +0.1109            43            47            43            47
BM_sinsp_concatenate_paths_absolute_path_stddev                +3.3326         +3.3310             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +2.8821         +2.8803             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0226         -0.0225           349           341           349           341
BM_sinsp_split_container_image_median                          -0.0258         -0.0257           350           340           349           340
BM_sinsp_split_container_image_stddev                          -0.4035         -0.4031             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3897         -0.3894             0             0             0             0

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (5ed00b2) to head (e3b897a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2041   +/-   ##
=======================================
  Coverage   74.30%   74.30%           
=======================================
  Files         253      253           
  Lines       30966    30966           
  Branches     5414     5406    -8     
=======================================
  Hits        23010    23010           
+ Misses       7951     7945    -6     
- Partials        5       11    +6     
Flag Coverage Δ
libsinsp 74.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 2, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Sep 2, 2024
@poiana poiana merged commit 1db10b3 into master Sep 2, 2024
46 checks passed
@poiana poiana deleted the cleanup/ci_fork branch September 2, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants