chore(cmake): honor CMAKE_BUILD_TYPE while building bundled grpc and protobuf #2043
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Another fix needed for
zig
(or well, this makes sense in a broader way, but iszig
that highlighted the issue).Otherwise Falco build would fail at link time because:
Caused by the fact that we built protobuf with
-DNDEBUG
(the default value, ie: release mode) but then we built Falco in Debug mode in PR's CI; then, when linking, we were hit by: protocolbuffers/protobuf#9947Another solution would've been to bump protobuf, but of course it requires to bump grpc and that's a circle of hell.
Don't really know why
g++
nor x86_64 zig were not hit by the issue at all, but zig arm64 was.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: