Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmake): honor CMAKE_BUILD_TYPE while building bundled grpc and protobuf #2043

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 3, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Another fix needed for zig (or well, this makes sense in a broader way, but is zig that highlighted the issue).
Otherwise Falco build would fail at link time because:

undefined symbol: google::protobuf::internal::InternalMetadata::~InternalMetadata()

Caused by the fact that we built protobuf with -DNDEBUG (the default value, ie: release mode) but then we built Falco in Debug mode in PR's CI; then, when linking, we were hit by: protocolbuffers/protobuf#9947

Another solution would've been to bump protobuf, but of course it requires to bump grpc and that's a circle of hell.

Don't really know why g++ nor x86_64 zig were not hit by the issue at all, but zig arm64 was.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

…protobuf.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 3, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Sep 3, 2024
@poiana poiana added the size/S label Sep 3, 2024
@poiana poiana added the approved label Sep 3, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 3, 2024

My upstream test branch chore/zig_build was already updated to cherry pick these changes that finally allowed Falco zig PR to correctly build on arm64: https://github.com/falcosecurity/falco/actions/runs/10679890028/job/29600300776?pr=3307

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.31%. Comparing base (1db10b3) to head (005f397).
Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2043   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files         253      253           
  Lines       30966    30966           
  Branches     5418     5413    -5     
=======================================
  Hits        23011    23011           
+ Misses       7949     7941    -8     
- Partials        6       14    +8     
Flag Coverage Δ
libsinsp 74.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@Andreagit97 Andreagit97 modified the milestones: 0.19.0, 0.18.0 Sep 5, 2024
@poiana
Copy link
Contributor

poiana commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9d2d151 into master Sep 5, 2024
45 of 46 checks passed
@poiana poiana deleted the chore/protobuf_grpc_follow_cmake_build_type branch September 5, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants