Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(drivers): add a warning for not officially supported archs #421

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

Andreagit97
Copy link
Member

Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

This pull request wants to clarify which are officially supported. This doesn't mean that all other architectures won't work it only suggest that we are focusing our efforts on the officially supported ones.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP
FedeDP previously approved these changes Jun 22, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

IMHO this is a big step forward: declaring the officially supported architectures with a cmake warning is the best possible.

@poiana
Copy link
Contributor

poiana commented Jun 22, 2022

LGTM label has been added.

Git tree hash: 7fddc769352f93242bacf23b00d513a2510ed7ee

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@Andreagit97 Andreagit97 force-pushed the supported_architectures branch from 973b32f to 7491566 Compare June 24, 2022 08:48
@poiana poiana removed the lgtm label Jun 24, 2022
@poiana poiana requested a review from FedeDP June 24, 2022 08:48
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Jun 24, 2022
@poiana
Copy link
Contributor

poiana commented Jun 24, 2022

LGTM label has been added.

Git tree hash: d8ece2a8ef04f3f1b92171a9a709d4e59e72c1e9

@FedeDP
Copy link
Contributor

FedeDP commented Jun 27, 2022

/cc @leogr

@poiana poiana requested a review from leogr June 27, 2022 07:31
@poiana poiana merged commit e88daf1 into falcosecurity:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants