build: reorganize driver cmake vars #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…the driver from the build Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
poiana
added
release-note-none
kind/cleanup
dco-signoff: yes
kind/design
kind/feature
|
I really like this refinement! |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
|
I think this is great Leo! |
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
FedeDP
reviewed
Jun 22, 2022
| set(DRIVER_NAME "scap") | ||
| endif() | ||
|
|
||
| if(NOT DEFINED DRIVER_DEVICE_NAME) |
There was a problem hiding this comment.
This seems to be used by scap too:
There was a problem hiding this comment.
Ok, but it's not an issue. Since it's defined in driver_config.h which is autogenerated and included 👇
All others definition in driver_config.h work in the same way.
Am I wrong?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind design
/kind feature
Any specific area of the project related to this PR?
/area build
/area libscap
What this PR does / why we need it:
This is mainly required to allow Falco to include different versions of libs and drivers. Falco can now pull libs
WITH_DRIVER=Offand separately pull the driver. Without this patch, the driver target was always added.Some other minor improvements are included.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: