Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(test/drivers): extend modern bpf test framework to all drivers (part 1) #798

Closed
wants to merge 5 commits into from

Conversation

Andreagit97
Copy link
Member

@Andreagit97 Andreagit97 commented Dec 16, 2022

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

/area CI

/area tests

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This PR is the first part of the driver's test porting phase, here you can find the full PR #783.
More in detail, this PR adds:

  • extend the testing framework to all drivers (Cmake side). Note that we are able to run tests for all the drivers but drivers are not fixed so we have many failures with bpf and kmod.
  • rename the directory in test/drivers
  • test executable rewrite start_tests.cpp
  • fix a broken bpf_x.cpp test. This failure is due to the fact that now we use the scap engine instead of libpman so we have many more bpf syscalls called by the engine.
  • rename the LOCAL_TEST_SUITE to ACTION_SUITE. Here we could test generic actions like reading from the buffers.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

tests(test/drivers): extend modern bpf test framework to all drivers (part 1)

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@poiana
Copy link
Contributor

poiana commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from gnosek and hbrueckner December 16, 2022 16:14
@Andreagit97 Andreagit97 changed the title Maintainers/support test 1 tests(test/drivers): extend modern bpf test framework to all drivers (part 1) Dec 16, 2022
@Andreagit97
Copy link
Member Author

Andreagit97 commented Dec 16, 2022

I will close it and reopen ion another branch since here we have all jobs duplicated, i forgot to rename the branch :/

@Andreagit97
Copy link
Member Author

sorry for that :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants