Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify dropping management in modern bpf probe #802

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: unify dropping management in modern bpf probe #802

merged 2 commits into from
Dec 19, 2022

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area driver-modern-bpf

/area libscap-engine-modern-bpf

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This PR carries 2 fixes:

  • allow computing the sum of all drops (full ring buffer + event too large) like in all our drivers.
  • unify the logic between our drivers. In our drivers n_evts is the number of events that the driver should send to userspace according to its configuration. So this counter includes also the number of drops (for example due to full buffers). Before this patch, the modern probe didn't consider drops inside the n_evts.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97
update(userspace): compute the sum of all drops in modern probe
e94c847 
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@Andreagit97
fix(driver): drops should be considered in the total number of events…
6f9c7fe 
… seen by drivers

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@poiana poiana requested review from hbrueckner and leogr December 19, 2022 09:11
@FedeDP
Copy link
Contributor

FedeDP commented Dec 19, 2022

Makes sense.
/milestone 0.10.0.

@poiana
Copy link
Contributor

poiana commented Dec 19, 2022

@FedeDP: The provided milestone is not valid for this repository. Milestones in this repository: [0.11.0, next-driver]

Use /milestone clear to clear the milestone.

In response to this:

Makes sense.
/milestone 0.10.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

FedeDP
FedeDP approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Dec 19, 2022
@poiana
Copy link
Contributor

poiana commented Dec 19, 2022

LGTM label has been added.

Git tree hash: 301034266a2eeb516a658e598a34e2ea57d4c6d2

Molter73
Molter73 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link
Contributor

poiana commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,Molter73]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c513782 into falcosecurity:master Dec 19, 2022
@FedeDP FedeDP added this to the 0.10.0 milestone Dec 20, 2022
@FedeDP
Copy link
Contributor

FedeDP commented Dec 20, 2022

This needs to be backported to the 0.10.0 release branch.

@FedeDP FedeDP mentioned this pull request Dec 20, 2022
Merged
@FedeDP
Copy link
Contributor

FedeDP commented Jan 10, 2023

/milestone 0.10.1

@poiana poiana modified the milestones: 0.10.0, 0.10.1 Jan 10, 2023
@Andreagit97 Andreagit97 modified the milestones: 0.10.1, 4.0.1+driver Jan 10, 2023
@Andreagit97 Andreagit97 added this to the 0.10.1 milestone Jan 10, 2023
@FedeDP FedeDP mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@leogr leogr Awaiting requested review from leogr

Assignees

@FedeDP FedeDP

@Molter73 Molter73

Labels
approved area/driver-modern-bpf area/libscap-engine-modern-bpf dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/S
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Andreagit97 @FedeDP @poiana @Molter73