Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(build): update libcurl to 7.87.0 #807

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

LucaGuerra
Copy link
Contributor

Signed-off-by: Luca Guerra luca@guerra.sh

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Update libcURL to the latest version, fixing 7 potential security vulnerabilities (none of them critically impacting Falco as far as I understand) disclosed in the last months, including CVE-2022-43551 and CVE-2022-43552 disclosed today. See: https://curl.se/docs/security.html .

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 21, 2022

LGTM label has been added.

Git tree hash: e32dc29685c969400af44cdcb0bfae26be6213d2

@@ -539,7 +539,7 @@ int mesos_http::get_socket(long timeout_ms)

check_error(curl_easy_perform(m_select_curl));

check_error(curl_easy_getinfo(m_select_curl, CURLINFO_LASTSOCKET, &sockextr));
check_error(curl_easy_getinfo(m_select_curl, CURLINFO_ACTIVESOCKET, &sockextr));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind to explain this change? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, look at the description: https://curl.se/libcurl/c/CURLINFO_LASTSOCKET.html . In fact, that is now going to emit a warning!

@Andreagit97 Andreagit97 added this to the 0.11.0 milestone Dec 21, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks!

@poiana
Copy link
Contributor

poiana commented Dec 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 5984498 into falcosecurity:master Dec 21, 2022
@LucaGuerra LucaGuerra deleted the chore/update-libcurl-7.87.0 branch December 21, 2022 14:45
@Andreagit97 Andreagit97 modified the milestones: 0.11.0, 0.10.1 Jan 10, 2023
@FedeDP FedeDP mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants