-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(build): update libcurl to 7.87.0 #807
update(build): update libcurl to 7.87.0 #807
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: e32dc29685c969400af44cdcb0bfae26be6213d2
|
@@ -539,7 +539,7 @@ int mesos_http::get_socket(long timeout_ms) | |||
|
|||
check_error(curl_easy_perform(m_select_curl)); | |||
|
|||
check_error(curl_easy_getinfo(m_select_curl, CURLINFO_LASTSOCKET, &sockextr)); | |||
check_error(curl_easy_getinfo(m_select_curl, CURLINFO_ACTIVESOCKET, &sockextr)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind to explain this change? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, look at the description: https://curl.se/libcurl/c/CURLINFO_LASTSOCKET.html . In fact, that is now going to emit a warning!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Luca Guerra luca@guerra.sh
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Update libcURL to the latest version, fixing 7 potential security vulnerabilities (none of them critically impacting Falco as far as I understand) disclosed in the last months, including CVE-2022-43551 and CVE-2022-43552 disclosed today. See: https://curl.se/docs/security.html .
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: