Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed bump of Falco engine version #28

Closed
loresuso opened this issue Feb 14, 2023 · 3 comments
Closed

Missed bump of Falco engine version #28

loresuso opened this issue Feb 14, 2023 · 3 comments

Comments

@loresuso
Copy link
Member

loresuso commented Feb 14, 2023

Describe the bug

As described in falcosecurity/falco#2418, we missed incrementing FALCO_ENGINE_VERSION for the latest Falco release. #20 is the first PR taking advantage of one of the newly introduced fields and should bump the required_engine_version to its proper number, which would be 16. However, since we have falcoctl that is now able to follow new rules, extra care should be taken: a Falco 0.34.0 ingesting the new rules containing the one that we are introducing in PR #20, will fail to restart since it is stuck at version 15.
A possible way to avoid this is to properly tag rules in a way that the new ones are not downloaded. Since in the Helm charts we are following tag 0, I think a bump of the major is needed.

@leogr leogr added this to the falco-rules-0.2 milestone Mar 19, 2023
@leogr
Copy link
Member

leogr commented Mar 19, 2023

I agree with the proposed solution.

/kind bug

I'm assigning this to
/milestone falco-rules-0.2

However, if we agree to switch to 1.0.0 (and leave the 0.x untouched with this non-addressable issue), I will rename just rename the milestone.

cc @falcosecurity/rules-maintainers

@poiana
Copy link

poiana commented Mar 19, 2023

@leogr: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

I agree with the proposed solution.

/kind bug

I'm assigning this to
/milestone falco-rules-0.2

However, if we agree to switch to 1.0.0 (and leave the 0.x untouched with this non-addressable issue), I will rename just rename the milestone.

cc @falcosecurity/rules-maintainers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@loresuso
Copy link
Member Author

loresuso commented Jun 8, 2023

With the release of the version of the rules 1.0.0, this issue can be considered addressed. Closing.

@loresuso loresuso closed this as completed Jun 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Falco Roadmap Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants