Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(RELEASE.md): add initial release guidelines #12

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

jasondellaluce
Copy link
Contributor

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

Providing correct guidelines for releasing and versioning rulesets is crucial for ensuring that Falco behaves correctly, specially considering the degree of automation that falcoctl will introduce.

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a few doubts, otherwise SGTM!

See my comments below!

RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
jasondellaluce and others added 2 commits January 18, 2023 14:09
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Co-authored-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce
Copy link
Contributor Author

Applied all the suggestions! Thanks.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. Thank you!

/approve

As a side note, it would be awesome if we could introduce a CI check to check (some of) those rules before merging PRs. I'm going to open an issue to do not forget 👼

@poiana
Copy link

poiana commented Jan 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 18, 2023

LGTM label has been added.

Git tree hash: 24a6202de68c53db9defbba35706819698d49721

@poiana poiana merged commit b3059c1 into main Jan 18, 2023
@poiana poiana deleted the docs/release-guidelines branch January 18, 2023 13:22
@jasondellaluce jasondellaluce added this to the falco-rules-0.1.0 milestone Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants