-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(RELEASE.md): add initial release guidelines #12
Conversation
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a few doubts, otherwise SGTM!
See my comments below!
Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Co-authored-by: Lorenzo Susini <susinilorenzo1@gmail.com> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Applied all the suggestions! Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now. Thank you!
/approve
As a side note, it would be awesome if we could introduce a CI check to check (some of) those rules before merging PRs. I'm going to open an issue to do not forget 👼
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 24a6202de68c53db9defbba35706819698d49721
|
Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com
Providing correct guidelines for releasing and versioning rulesets is crucial for ensuring that Falco behaves correctly, specially considering the degree of automation that falcoctl will introduce.