update k8s registry domain #30
Conversation
|
@cpanato: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @jasondellaluce |
There was a problem hiding this comment.
Since the rules can also run on environments not up-to-date, I'd keep both domains (ie k8s.grc.io and registry.k8s.io).
@LucaGuerra @darryk10 @loresuso wdyt? 🤔
Signed-off-by: cpanato <ctadeu@gmail.com>
| @@ -1859,6 +1859,7 @@ | |||
| - public.ecr.aws/falcosecurity/falco-no-driver | |||
|
|
|||
| # These container images are allowed to run with --privileged and full set of capabilities | |||
| # TODO: Remove k8s.gcr.io reference after 01/Dec/2023 | |||
There was a problem hiding this comment.
@leogr @LucaGuerra added this date to we remove the k8s reference after December
the k8s registry will be frozen on 3rd of April 2023 (https://kubernetes.io/blog/2023/02/06/k8s-gcr-io-freeze-announcement/) so we give some extra time for people to update the clusters.
wdyt?
cpanato
requested review from
leogr
and removed request for
loresuso and
darryk10
|
LGTM label has been added. Git tree hash: 5ed40d228aef6c2f08bcc3606e91735e705d4605
|
|
LGTM! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
part of kubernetes/k8s.io#4780
/assign @leogr
Not sure if we will need to keep both for while. will wait for some feedback
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: