Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build drivers more frequently (ideally every 2 hours) #1255

Closed
incertum opened this issue Oct 11, 2023 · 7 comments
Closed

Build drivers more frequently (ideally every 2 hours) #1255

incertum opened this issue Oct 11, 2023 · 7 comments

Comments

@incertum
Copy link
Contributor

Motivation

While modern_bpf adoption is projected to increase, many adopters appear to still rely on kernel module or traditional eBPF drivers. This statement is based on seeing Slack posts by community members saying that drivers for recent kernel releases are not yet available.

Therefore, proposing to increase the frequency of CI runs and if we were to hit budgeting limits, we can go ahead and file a ticket against the CNCF asking for an increase.

Feature

Run drivers build more frequently than weekly and/or occasionally manually.

Ideally: Every 2 hours.
Next Step: Daily or twice each day.

@FedeDP
Copy link
Contributor

FedeDP commented Oct 12, 2023

Ideally: Every 2 hours.

Considering that today the update-dbg test-infra job takes more than 2hrs and the update-kernels github action in kernel-crawler takes ~40mins, we are already > 2hrs; also, the PR needs to be merged in kernel-crawler to start the automation, therefore you'd need a man (ie: me) crazily approving PRs on kernel-crawler and then test-infra repo 😆
I think that daily is already good enough.

@FedeDP
Copy link
Contributor

FedeDP commented Oct 12, 2023

Considering that today the update-dbg test-infra job takes more than 2hrs

Luckily enough, the situation is going to improve once #1204 is merged since the update-dbg job will take a minute or so then :D

@FedeDP
Copy link
Contributor

FedeDP commented Oct 12, 2023

falcosecurity/kernel-crawler#179 propose a daily trigger for our action.
Thoughts?
cc @maxgio92 @LucaGuerra @leogr

@leogr
Copy link
Member

leogr commented Oct 12, 2023

I'd start with daily updates and we will see if it is sustainable. Then we can fine tune eventually.

@maxgio92
Copy link
Member

I agree @FedeDP

@FedeDP
Copy link
Contributor

FedeDP commented Oct 19, 2023

This is now closed by latest kernel-crawler and test-infra development!
Kernel-crawler will run daily, then test-infra update-dbg job will run a couple of hrs after the kernel-crawler one.
Kernel-crawler job will directly deploy generated jsons to github pages instead of pushing them to a long living repo, allowing us to also fix #1118 .
This way, with just a single approve (ie: the one on the PR generated by update-dbg) we will have daily drivers builds!
/close

@poiana
Copy link
Contributor

poiana commented Oct 19, 2023

@FedeDP: Closing this issue.

In response to this:

This is now closed by latest kernel-crawler and test-infra development!
Kernel-crawler will run daily, then test-infra update-dbg job will run a couple of hrs after the kernel-crawler one.
Kernel-crawler job will directly deploy generated jsons to github pages instead of pushing them to a long living repo, allowing us to also fix #1118 .
This way, with just a single approve (ie: the one on the PR generated by update-dbg) we will have daily drivers builds!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants