Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(config/clusters/ecr.tf): removed old autobumper ecr resource. #1194

Merged

Conversation

cappellinsamuele
Copy link
Contributor

Completes #1132 and #1133 .

@poiana poiana requested review from jonahjon and maxgio92 July 5, 2023 15:25
@cappellinsamuele cappellinsamuele changed the title cleanup(config/clusters/ecr.tf): removed old autobumper ecr resource. wip: cleanup(config/clusters/ecr.tf): removed old autobumper ecr resource. Jul 5, 2023
Signed-off-by: cappellinsamuele <cappellinsamuele@gmail.com>
@cappellinsamuele cappellinsamuele force-pushed the cleanup/ecr_autobump_removal branch from deffae0 to 9403f80 Compare July 5, 2023 15:34
@poiana poiana added size/S and removed size/XS labels Jul 5, 2023
@cappellinsamuele cappellinsamuele changed the title wip: cleanup(config/clusters/ecr.tf): removed old autobumper ecr resource. cleanup(config/clusters/ecr.tf): removed old autobumper ecr resource. Jul 5, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cappellinsamuele, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jul 5, 2023

LGTM label has been added.

Git tree hash: f2bfbad00e594c8e141b6a73a0d69edb5a1fb695

@poiana poiana added the approved label Jul 5, 2023
@poiana poiana merged commit 36666d7 into falcosecurity:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants