-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(OWNERS): remove inactive approvers #751
cleanup(OWNERS): remove inactive approvers #751
Conversation
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
022b9fc
to
08c4e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Citing our governance:
... they will be contacted to ask whether they want to continue being a maintainer. If they decide to step down they open a pull request to be removed from the OWNERS files.
Please read the governance again, and restore leodido
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please restore fntlnz
https://github.com/falcosecurity/falco/issues/2115#issuecomment-1176045086
Sorry, I wasn't aware of the missing contact. If maintainers want to be kept, it should be considered, as for the governance. |
I apologize for the confusion. I have tried to clarify the process in this comment 👇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 2ad921c0050558629b44749dce45f8117ebe0407
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been on hold for 12 days now. I think we all agree to merge this change. However, since it stuck because of the pending "change requests", I'd ask @jasondellaluce to close this PR and open a new one.
cc @maxgio92 @jonahjon @zuc
Closing this in favor of #768 . /close |
@jasondellaluce: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from
approvers
toemeritus_approvers
in OWNERS.