Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(OWNERS): remove inactive approvers #751

Conversation

jasondellaluce
Copy link
Contributor

For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from approvers to emeritus_approvers in OWNERS.

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce jasondellaluce force-pushed the cleanup/inactive-owners branch from 022b9fc to 08c4e94 Compare July 5, 2022 16:13
@poiana poiana added size/M and removed size/S labels Jul 5, 2022
@maxgio92 maxgio92 self-requested a review July 5, 2022 18:34
Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@zuc
Copy link
Member

zuc commented Jul 6, 2022

/hold
(we are doing cluster mainteinance)

@zuc
Copy link
Member

zuc commented Jul 6, 2022

/unhold

Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citing our governance:

... they will be contacted to ask whether they want to continue being a maintainer. If they decide to step down they open a pull request to be removed from the OWNERS files.

Please read the governance again, and restore leodido.

Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxgio92
Copy link
Member

maxgio92 commented Jul 6, 2022

Sorry, I wasn't aware of the missing contact. If maintainers want to be kept, it should be considered, as for the governance.

@leogr leogr requested review from fntlnz and leodido July 13, 2022 13:35
@leogr
Copy link
Member

leogr commented Jul 13, 2022

Sorry, I wasn't aware of the missing contact. If maintainers want to be kept, it should be considered, as for the governance.

I apologize for the confusion. I have tried to clarify the process in this comment 👇
falcosecurity/evolution#157

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood correctly @leodido and @fntlnz decided to step down in the end (if so, please dismiss your change request that is blocking this pull request,).

@poiana
Copy link
Contributor

poiana commented Jul 13, 2022

LGTM label has been added.

Git tree hash: 2ad921c0050558629b44749dce45f8117ebe0407

@poiana
Copy link
Contributor

poiana commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been on hold for 12 days now. I think we all agree to merge this change. However, since it stuck because of the pending "change requests", I'd ask @jasondellaluce to close this PR and open a new one.
cc @maxgio92 @jonahjon @zuc

@jasondellaluce
Copy link
Contributor Author

This PR has been on hold for 12 days now. I think we all agree to merge this change. However, since it stuck because of the pending "change requests", I'd ask @jasondellaluce to close this PR and open a new one. cc @maxgio92 @jonahjon @zuc

Closing this in favor of #768 .

/close

@poiana
Copy link
Contributor

poiana commented Jul 19, 2022

@jasondellaluce: Closed this PR.

In response to this:

This PR has been on hold for 12 days now. I think we all agree to merge this change. However, since it stuck because of the pending "change requests", I'd ask @jasondellaluce to close this PR and open a new one. cc @maxgio92 @jonahjon @zuc

Closing this in favor of #768 .

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants