-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New/rule matching tests #19
Conversation
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
b6eeaa8
to
d88b92b
Compare
d88b92b
to
cc80b4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I only left you a minor suggestion.
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
cc80b4a
to
473c610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Merging this and covering the tests in falcosecurity/falco#2705.
LGTM label has been added. Git tree hash: 3076d8f8df0f6085bed5c362b280908a156360d9
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, loresuso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR introduces testing for rule matching strategy configuration key.
For further details, please refer to falcosecurity/falco#2705