Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/rule matching tests #19

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Aug 2, 2023

This PR introduces testing for rule matching strategy configuration key.
For further details, please refer to falcosecurity/falco#2705

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@poiana poiana added the size/M label Aug 2, 2023
@loresuso loresuso force-pushed the new/rule-matching-tests branch from b6eeaa8 to d88b92b Compare August 2, 2023 13:07
@poiana poiana added size/L and removed size/M labels Aug 2, 2023
@loresuso loresuso force-pushed the new/rule-matching-tests branch from d88b92b to cc80b4a Compare August 2, 2023 13:08
Copy link
Collaborator

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I only left you a minor suggestion.

tests/falco/config_test.go Outdated Show resolved Hide resolved
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@loresuso loresuso force-pushed the new/rule-matching-tests branch from cc80b4a to 473c610 Compare August 7, 2023 14:11
Copy link
Collaborator

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Merging this and covering the tests in falcosecurity/falco#2705.

@poiana
Copy link

poiana commented Aug 8, 2023

LGTM label has been added.

Git tree hash: 3076d8f8df0f6085bed5c362b280908a156360d9

@poiana
Copy link

poiana commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Aug 8, 2023
@poiana poiana merged commit bbb796b into falcosecurity:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants