Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update test with latest libs fix #60

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Andreagit97
Copy link
Member

@Andreagit97 Andreagit97 commented Jun 25, 2024

Test TestFalco_Legacy_NonSudoSetuid was affected by the bug reported here falcosecurity/libs#1923. A thread with vtid=-1 was considered as a container thread and for this reason, we didn't match the rule because of this condition container and not user.name in ("<NA>","N/A",""). The user is NA and before the fix, we were considered in a container.

Now with the fix, we are no longer in a container so the rule correctly triggers. Full rule output with addition of thread.vtid and thread.tid

22:23:30.177328055: Notice Unexpected setuid call by non-sudo, non-root program (user=<NA> tid=10397, vtid=<NA> user_loginuid=-1 cur_uid=4294967295 parent=<NA> command=<NA> pid=-1 uid=root container_id= image=<NA>)

ref libs PR: falcosecurity/libs#1923

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@poiana
Copy link

poiana commented Jun 25, 2024

LGTM label has been added.

Git tree hash: c567ea581a061e5a3cbbe1bd15be3b5a88b5e209

@poiana
Copy link

poiana commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 32e319a into falcosecurity:main Jun 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants