Obtain version on class init, allow compatibility with 2.x and 3.x APIs. #151
Conversation
|
I like the idea, although I'm not a fan of the mandatory nature of this. I'd like to be able to opt out of this version check (or move it only to calls where version matters). For example, I use this library for TrustSec elements in ISE, and none of those APIs have changed in a breaking way. So forcing the additional loading time isn't something that I enjoy. |
|
I'm not sure why I changed that timeout. It certainly doesn't take 4 seconds. I profiled the code performance. The change is just a 200ms sanity check on initialization to verify if the API is working - rather than writing guards deeper in your code. One more benefit doing this in class init you immediately know if the ISE object is valid. If the version is populated, you know the class is primed and ready to use. Initialization will also be helpful in HA deployments too. The primary node ERS API is read/write, but the secondary node ERS API is read-only. If there is a failover event, the library could use initialization to determine the active node for ERS, and redirect the call to the current primary. That's outside this issue, but a great case for heading down the path of active initialization rather than passive. |
|
Hi, great PR! -- |
|
Arrh, I must reinstall my ISE dev env. |
|
I got some problems with this if the user that connects to ers don't have a admin account to webui. And sorry bout the mess with the merge / revert :) -- |
|
My fault, if it is ok for you. Can you recommit the PR? -- |
|
Ok... @falkowich I'm sorry, I've been on vacation, catching up. I'm a little lost. It looks like it was committed, then it was reverted, and both issues are marked closed. I'm not sure what you'd like me to do - perhaps resubmit a fresh PR? |
Was looking for a few ISE calls to support a NetBox plugin for ISE and this worked well for adding and deleting endpoints, and I started thinking about 3.x support.
There is a workaround suggested on the Issue thread, but it requires modifying the library and maintaining a fork of the code vs the Pypi library, and, it doesn't have backward compatibility which I would like.
The idea is the class will initialize with a slightly longer timeout (changing from 2 -> 4 seconds) to obtain the version from the ISE API. If it succeeds, it stores a short version string on the class, if not, it's just empty ''.
If this direction is approved, this could determine how to obtain backwards compatibility and call functions differently and automatically on 2.x vs 3.x.
Tag: Issue #148 ISE 3.x support.