Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getKeyValuePair API on ObjectElement #85

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add getKeyValuePair API on ObjectElement #85

merged 1 commit into from
Nov 27, 2024

Conversation

Fox2Code
Copy link
Contributor

This makes ObjectElement a lot more flexible without doing anything fancy.

falkreon
falkreon requested changes Nov 27, 2024
View reviewed changes
Copy link
Owner

@falkreon falkreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also seems in-scope for this PR, if you're interested, to add a method returning an Iterator<KeyValuePair> (or ListIterator), which could potentially avoid a linear search per element if we're already going through every pair.

src/main/java/blue/endless/jankson/api/document/ObjectElement.java Outdated Show resolved Hide resolved
@Fox2Code Fox2Code force-pushed the ObjectElement_getKeyValuePair branch from d39e38c to fc5d85c Compare November 27, 2024 21:22
@Fox2Code Fox2Code requested a review from falkreon November 27, 2024 21:40
@Fox2Code Fox2Code force-pushed the ObjectElement_getKeyValuePair branch from fc5d85c to 5f7dc0f Compare November 27, 2024 21:50
falkreon
falkreon approved these changes Nov 27, 2024
View reviewed changes
Copy link
Owner

@falkreon falkreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might tweak the wording later if I remember, but it'll be understood this way just fine. I'm merging it.

@falkreon falkreon merged commit 129b2bb into falkreon:main Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkreon falkreon falkreon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fox2Code @falkreon