Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On adding photo, scroll into view #612

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

wbazant
Copy link
Collaborator

@wbazant wbazant commented Nov 22, 2024

Closes #556

scroll-after-upload.mp4

wbazant and others added 2 commits November 22, 2024 11:54
Otherwise the submit button tends to get lost
Copy link
Collaborator

@ezwelty ezwelty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbazant Fancy! I like the effect, but didn't like the extra 100 px it inserted between the photo list and the submit button. I dropped the -100 px margin and set the height to 0 px and see no side effects. Good to merge if you don't either.

@wbazant
Copy link
Collaborator Author

wbazant commented Nov 27, 2024

Thanks, it does still work!

@wbazant wbazant merged commit 03ff925 into falling-fruit:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After adding a photo, the submit button slides down
2 participants