Recompile inotifywait.exe; test w/ Elixir 1.18 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently updated version does not match the bundled sources and probably came from the upstream, which currently doesn't watch for closed STDIN which Port needs to cleanly shut down the process. Recompile bundled sources that do have the feature and update the binary.
dtcaciuc
commented
Jan 5, 2025
| @@ -4,8 +4,9 @@ defmodule FileSystemTest do | |||
| @moduletag os_linux: true, os_macos: true, os_windows: true | |||
|
|
|||
| test "file event api" do | |||
| tmp_dir = System.cmd("mktemp", ["-d"]) |> elem(0) |> String.trim() | |||
There was a problem hiding this comment.
AFAIK this command does not normally come with Windows and was absent on my machine.
I borrowed this mktemp_d implementation from the internets and it's not bulletproof but should be good enough for our purposes.
|
the CI passed, then let's merge it and I'll bump a version, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently updated version does not match the bundled sources and probably came from the upstream, which currently doesn't watch for closed STDIN which Port needs to cleanly shut down the process.
Recompile bundled sources that do have the feature and update the binary.
Fixes #102