-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][WEBSITE-1155] Remove unused CSS Styles from Bootstrap #2148
[Fix][WEBSITE-1155] Remove unused CSS Styles from Bootstrap #2148
Conversation
@mmoraes, do you think you you could use Those are provided by the gem already, as they're also updated when we update the gem. |
@tiagoamaro @ElGrecode We currently cannot use What can we do in this case, in order to keep Bootstrap's CSS maintainable in our end? |
Btw, @mmoraes , if you're planning to introduce vendored bootstrap SASS, feel free to remove its gemified version (actually 🎉 for that). |
@mmoraes , did two changes:
|
529df47
to
86d3dc5
Compare
👍 This should allow us to comb down naturally after this as well. Small savings is still savings 🎉 |
Thanks for the help, @tiagoamaro! 🎉 |
@tiagoamaro, I just tested this again and I think it's OK to ship. Much better this way! |
LGTM Moving this to QA. |
Note: #2205 is just waiting for this PR to be merged. |
86d3dc5
to
cfd11c0
Compare
cfd11c0
to
a992fd3
Compare
JIRA
https://fameandpartners.atlassian.net/browse/WEBSITE-1155
Summary
Removal of a few unused Bootstrap CSS styles, in order to reduce the size of our CSS file.
Locally, with our current configs, it seems like it saved
~34kb
.BONUS:
Now that we are loading Bootstrap styles as separate SCSS partial files it's also possible to use its mixins and variables.
Note: I've left the unused CSS files to make it easier to reenable them in the future (by just commenting out the main scss file - 6b1c2d5).
Reviewers List